Skip to content

fix and update experimental Next.js template to work on @opennextjs/[email protected] #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 30, 2024
Merged

fix and update experimental Next.js template to work on @opennextjs/[email protected] #7638

merged 6 commits into from
Dec 30, 2024
+50 −10

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Dec 27, 2024 •
edited
Loading

Changes made in @opennextjs/[email protected] haven't been updated in the C3 experimental template causing C3 to currently create broken open-next applications, this PR is addressing that plus some other small minor related updates.

@dario-piotrowicz dario-piotrowicz requested a review from a team December 27, 2024 09:58
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 27, 2024 09:58
@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ea5ba02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-wrangler-7638

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7638/npm-package-wrangler-7638

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-wrangler-7638 dev path/to/script.js
Additional artifacts: 
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workers-bindings-extension-7638 -O ./cloudflare-workers-bindings-extension.0.0.0-v4fda7eecd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v4fda7eecd.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-create-cloudflare-7638 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-kv-asset-handler-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-miniflare-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-pages-shared-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-unenv-preset-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-vitest-pool-workers-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workers-editor-shared-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workers-shared-7638
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workflows-shared-7638

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz added the e2e Run wrangler + vite-plugin e2e tests on a PR label Dec 27, 2024
@dario-piotrowicz dario-piotrowicz mentioned this pull request Dec 27, 2024
Closed
@dario-piotrowicz dario-piotrowicz force-pushed the dario/next-experimental/opennext-0.3 branch from 37fecf2 to e7f4eea Compare December 27, 2024 10:57
vicb
vicb requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Could you please also add a .dev.vars, using https://github.com/flarelabs-net/workers-next/blob/main/.dev.vars.example as a template

@dario-piotrowicz dario-piotrowicz mentioned this pull request Dec 27, 2024
Merged
2 tasks
vicb
vicb approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Maybe create an issue on https://github.com/opennextjs/docs to update the docs when this PR is released to c3

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 27, 2024 •
edited
Loading

Thanks.

Maybe create an issue on https://github.com/opennextjs/docs to update the docs when this PR is released to c3

This is the Next.js guide that uses the open-next adapter: https://developers.cloudflare.com/workers/frameworks/framework-guides/nextjs/

I don't think there's anything in the changes I'm making that needs updating there (otherwise I'd do open a PR right away and merge it after the C3 release)

@vicb
Copy link
Contributor

vicb commented Dec 27, 2024

Thanks.
Maybe create an issue on https://github.com/opennextjs/docs to update the docs when this PR is released to c3

This is the Next.js guide that uses the open-next adapter: https://developers.cloudflare.com/workers/frameworks/framework-guides/nextjs/

I don't think there's anything in the changes I'm making that needs updating there (otherwise I'd do open a PR right away and merge it after the C3 release)

We need to update that which is repeated multiple times to use the c3 experimental template

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 27, 2024 •
edited
Loading

Thanks.
Maybe create an issue on https://github.com/opennextjs/docs to update the docs when this PR is released to c3

This is the Next.js guide that uses the open-next adapter: https://developers.cloudflare.com/workers/frameworks/framework-guides/nextjs/
I don't think there's anything in the changes I'm making that needs updating there (otherwise I'd do open a PR right away and merge it after the C3 release)

We need to update that which is repeated multiple times to use the c3 experimental template

ah ok, sorry I thought we were talking about the Cloudflare docs 👍 (I missed that you were actually linking to the opennextjs docs 🤦)

@dario-piotrowicz
Copy link
Member Author

@vicb opennextjs/docs#44 👍

@vicb vicb mentioned this pull request Dec 28, 2024
Merged
@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 30, 2024 •
edited
Loading

Merging this PR as the only failing tests are e2es (both experimental and not) running nuxt using yarn under ubuntu and:

  • this PR is completely unrelated to nuxt
  • I can see the same failures in other existing PRs

I've opened a followup PR to address the Nuxt issue: #7648

@dario-piotrowicz dario-piotrowicz merged commit acbea32 into main Dec 30, 2024
29 of 31 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/next-experimental/opennext-0.3 branch December 30, 2024 10:10
@workers-devprod workers-devprod mentioned this pull request Dec 30, 2024
Merged
penalosa pushed a commit that referenced this pull request Jan 10, 2025
@dario-piotrowicz @penalosa
fix and update experimental Next.js template to work on `@opennextjs/…
b5509b5 
…[email protected]` (#7638)

* update the experimental Next.js template to work on `@opennextjs/[email protected]`
* include `.dev.vars` template file
* skip bun and yarn experimental e2es
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

@edmundhung edmundhung edmundhung approved these changes

Assignees

No one assigned

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dario-piotrowicz @vicb @edmundhung